T Compiler Meeting Agenda 2022 02 17

T-compiler Meeting Agenda 2022-02-17

Tracking Issue

Announcements

  • :loudspeaker: Next Thursday, February 24th, release Rust stable 1.59 :loudspeaker:
  • Reminder: if you see a PR/issue that seems like there might be legal implications due to copyright/IP/etc, please let the Core team know (or at least message @pnkfelix or @Wesley Wiser so we can pass it along).

MCPs/FCPs

  • New MCPs (take a look, see if you like them!)
    • No new proposals this time.
  • Old MCPs (not seconded, take a look)
    • “Accept pc in place of unknown and unknown in place of pc for x86_64 and i?86 targets” compiler-team#441 (last review activity: 7 months ago)
    • “Make -Z binary-dep-depinfo the default behavior” compiler-team#464 (last review activity: 4 months ago)
    • “Tier 3 target proposal: riscv64gc-linux-android (Android target for riscv64gc)” compiler-team#472 (last review activity: 2 months ago)
    • “-Dwarnings to cover all warnings” compiler-team#473 (last review activity: 2 months ago)
    • “Build-time execution sandboxing” compiler-team#475 (last review activity: about 52 days ago)
    • “Dealing with type/const ambiguities” compiler-team#480 (last review activity: about 27 days ago)
  • Pending FCP requests (check your boxes!)
    • No pending FCP requests this time.
  • Things in FCP (make sure you’re good with it)
  • Accepted MCPs
  • Finalized FCPs (disposition merge)
    • No new finished FCP (disposition merge) this time.

WG checkins

  • @_wg-incr-comp by @pnkfelix @Wesley Wiser (previous checkin, goes back to Sept. 2021, I think no more recent updates were filed)

Nothing to report from the Working Group. Wesley and Felix are looking into moving ownership of this working group to the people who are actively owning it, so to speak.

  • There is an ongoing upgrade to LLVM 14 which is going to land soon (https://github.com/rust-lang/rust/pull/93577). Don’t think there is anything especially noteworthy about this release as far as rust is concerned, but expect the usual mix of things getting fixed and other things getting broken :)
  • We now apply noundef to some function parameters and returns (https://github.com/rust-lang/rust/pull/93670). A resolution of https://github.com/rust-lang/unsafe-code-guidelines/issues/71 towards “uninitialized outside MaybeUninitialized is always UB, no ifs or buts” would be appreciated.
  • @durin42 has been working on upstream patches to encode allocator information via attributes. This will eliminate the main “functional” patch to LLVM we carry (the rest is mostly build fixes and backports).
  • I’ve been focused on opaque pointers work upstream, which reached a milestone last week: We can now do end-to-end optimized compiles of most C/C++ code. Plan to test this with rust soonishly.

Backport nominations

T-compiler beta / T-compiler stable

  • No backport nominations for T-compiler this time.

T-rustdoc beta / T-rustdoc stable

  • No backport nominations for T-rustdoc this time.

:back: / :shrug: / :hand:

PRs S-waiting-on-team

T-compiler

  • No PRs waiting on t-compiler

Oldest PRs waiting for review

T-compiler

  • “Introduce linter for diagnostic messages” rust#89455 (last review activity: 4 months ago)
  • “Specialize infinite-type “insert some indirection” suggestion for Option” rust#91416 (last review activity: 2 months ago)
    • seems to be waiting on @estebank
    • perhaps also an update due to upstream changes making this unmergeable
  • “Fold aarch64 feature +fp into +neon” rust#91608 (last review activity: 2 months ago)
    • latest comment from PR author seems to indicate some disagreement on the motivation (cc: @Amanieu @Adam Gemmell)
    • (maybe leave some more time to review and go over this again later)
  • “Update to fix regression 90319 and correctly emit overflow errors when not inside an error reporting context” rust#91238 (last review activity: 2 months ago)
    • seems to be waiting on @estebank
  • “Implementation of the expect attribute (RFC 2383)” rust#87835 (last review activity: 2 months ago)
    • seems to be waiting on @Wesley Wiser

Issues of Note

Short Summary

P-critical

T-compiler

  • “Const generic defaults ICE: No bound vars found” rust#93647
    • Fixed by PR rust#93669 authored by @Michael Goulet (compiler-errors)
    • seems under control
  • “optimized i686 fails primal-sieve tests” rust#94032
    • This comment from @cuviper suggests that disabling the new LLVM Pass Manager fixes the issue
    • @Nikita Popov adds that it also happens with LLVM 14

T-rustdoc

  • No P-critical issues for T-rustdoc this time.

P-high regressions

P-high beta regressions

  • No P-high beta regressions this time.

Unassigned P-high nightly regressions

  • “Nightly compiler bug: “lifetime mismatch”” rust#94004

Performance logs

triage logs for 2022-02-16

Only one outright regression this week. We had some very cool work from cjgillot to prevent queries from doing expensive clones, by just forcing them all to be Copy! Also, nnethercote’s overhaul of interning yielded massive improvements across many crates. Also, a slew of benchmarks were unexpectedly improved quite a lot by some changes to way we invoke the linker when building LLVM itself.

Triage done by @pnkfelix. Revision range: 775e480722c7aba6ff4ff3ccec8c1f4639ae7889..a240ccd81c74c105b6f5fe84c46f8d36edb7e306

2 Regressions, 2 Improvements, 4 Mixed; 0 of them in rollups 47 comparisons made in total 30 Untriaged Pull Requests

Regressions

Inherit lifetimes for async fn instead of duplicating them. #91403

  • Average relevant regression: 1.7%
  • Largest regression in instruction counts: 2.0% on full builds of issue-88862 check
  • This regression was predicted by a rust-timer build when PR was first proposed, …
  • … but there was no follow-up on those results at that time; left comment on PR.

Apply noundef attribute to &T, &mut T, Box, bool #93670

  • Average relevant regression: 0.7%
  • Largest regression in instruction counts: 1.1% on full builds of regression-31157 debug
  • PR author says that Cachegrind indicates this is due to overhead of inserting attribute itself.
  • PR author also says there is related work in LLVM 14 that may help ease the performance impact here, so stay tuned for when that lands in PR #93577

Improvements

  • Ensure that queries only return Copy types. #93511
  • bootstrap: tidy up flag handling for llvm build #93918
  • Inline a few trivial conversion functions #94021

Mixed

Revert lazy TAIT PR #93893

  • Average relevant regression: 1.0%
  • Average relevant improvement: -1.2%
  • Largest improvement in instruction counts: -1.8% on full builds of deeply-nested-async check
  • Largest regression in instruction counts: 1.6% on full builds of wg-grammar check
  • Left comment: we had to revert the TAIT PR, the fallout from it was too high. Marked as triaged.

Implement tainted_by_errors in MIR borrowck, use it to skip CTFE #93691

  • Average relevant regression: 1.7%
  • Average relevant improvement: -0.4%
  • Largest improvement in instruction counts: -0.6% on incr-unchanged builds of keccak check
  • Largest regression in instruction counts: 2.4% on incr-patched: u8 3072 builds of issue-46449 debug
  • There were three experiments done for this PR, with distinct commits: first run, second run, third run.
  • The second experiment is what landed; the first experiment had smaller max and average values in its summary, but it regressed far more crates overall, while the second experiment regressed only a few crates, each by slightly more than the first experiment.
  • In any case, this was expected fallout from this PR.

make find_similar_impl_candidates even fuzzier #93298

  • Average relevant regression: 0.7%
  • Average relevant improvement: -0.3%
  • Largest improvement in instruction counts: -0.3% on full builds of inflate check
  • Largest regression in instruction counts: 0.8% on full builds of keccak check
  • Not clear why this had a performance impact at all, as it should have only affected error reporting.

Overhaul interning. #93148

  • Average relevant regression: 1.0%
  • Average relevant improvement: -1.1%
  • Largest improvement in instruction counts: -4.5% on full builds of projection-caching check
  • Largest regression in instruction counts: 1.8% on full builds of match-stress-enum check
  • This was a massive improvement, full stop.

Nags requiring follow up

  • None

Nominated Issues

T-compiler

  • “Stabilize native library modifier syntax and the whole-archive modifier specifically” rust#93901
    • opened and nominated by @Vadim Petrochenkov
    • Stabilization report for RFC 2951 at this comment

RFC

  • No nominated RFCs for T-compiler this time.