T-compiler Meeting Agenda 2024-03-21

Announcements

• Today release of rustc 1.77 stable
• “Enable frame pointers for the standard library” rust#122646
  • suggested by @_nils (Nilstrieb) (comment): FIY to T-compiler as it’s a perhaps impacting change
• Reminder: if you see a PR/issue that seems like there might be legal implications due to copyright/IP/etc, please let us know (or at least message @davidtwco or @Wesley Wiser so we can pass it along).

Other WG meetings (calendar link)

• Types Team: ITE (Impl Trait Everywhere) Triage time:2024-03-21T22:00:00+01:00

MCPs/FCPs

• New MCPs (take a look, see if you like them!)
  • “Skip virtual drop for !needs_drop types” compiler-team#730 (Zulip)
• Old MCPs (stale MCP might be closed as per MCP procedure)
  • None at this time
• Old MCPs (not seconded, take a look)
  • “Target families for executable format” compiler-team#716 (Zulip) (last review activity: about 48 days ago)
  • “Add --emit= to emit nothing” compiler-team#718 (Zulip) (last review activity: about 48 days ago)
  • “Promote riscv64gc-unknown-linux-musl to tier 2” compiler-team#728 (Zulip) (last review activity: about 13 days ago)
• Pending FCP requests (check your boxes!)
  • “Tracking Issue for RFC 3013: Checking conditional compilation at compile time” rust#82450
  • “Stabilize Wasm target features that are in phase 4 and 5” rust#117457
  • “Stabilize --env-set option” rust#119926
  • “Make casts of pointers to trait objects stricter” rust#120248
  • “sess: stabilize -Zrelro-level as -Crelro-level” rust#121694
  • “Add encoding for f16 and f128” rust#122106
• Things in FCP (make sure you’re good with it)
  • “Dist rustc with overflow checks” compiler-team#724 (Zulip)
• Accepted MCPs
  • No new accepted proposals this time.
• MCPs blocked on unresolved concerns
  • “Add a new --build-id flag to rustc” compiler-team#635 (Zulip)
    • concern: other-existing-options
    • concern: option-name
  • “Retire the mailing list and make all decisions on zulip” compiler-team#649 (Zulip)
    • concern: automatic-sync
    • concern: single-point-of-failure-via-stream-archival
  • “Add hygiene attributes to compile expanded source code” compiler-team#692 (Zulip) (last review activity: 2 months ago)
    • concern: added-complexity-to-frontend
• Finalized FCPs (disposition merge)
  • “rework opaque type region inference” rust#116891
  • “instantiate higher ranked goals outside of candidate selection” rust#119820
• Other teams finalized FCPs
  • “Tracking issue for Allow a re-export for main (RFC 1260)” rust#28937
  • “c_unwind full stabilization request: change in extern "C" behavior” rust#115285
  • “rework opaque type region inference” rust#116891
  • “Prevent opaque types being instantiated twice with different regions within the same function” rust#116935
  • “instantiate higher ranked goals outside of candidate selection” rust#119820
  • “Split refining_impl_trait lint into _reachable, _internal variants” rust#121720
  • “Stabilize associated type bounds (RFC 2289)” rust#122055

WG checkins

• @_WG-rustc-dev-guide by @Santiago Pastorino and @Yuki Okushi|217081

  Checkin text

• Impl Trait initiative by @oli

  Checkin text

Backport nominations

T-compiler beta / T-compiler stable

• :beta: [1.78] “Make #[diagnostic::on_unimplemented] format string parsing more robust” rust#122402
  • Fixes #122391, a few diagnostic errors
  • Nominated by @Michael Goulet (compiler-errors) (comment) to stabilize it at the same time as diagnostic::on_unimplemented

• :beta: [1.78] “Do not eat nested expressions' results in MayContainYieldPoint format args visitor” rust#122680
  • authored by @lqd, fixes #122674, a nightly miscompilation. Due to release timeline the issue is on beta right now

• No stable nominations for T-compiler this time.

T-types stable / T-types beta

• No beta nominations for T-types this time.
• No stable nominations for T-types this time.

PRs S-waiting-on-team

T-compiler

• Issues in progress or waiting on other teams

Issues of Note

Short Summary

• 0 T-compiler P-critical issues
  • 0 of those are unassigned
• 64 T-compiler P-high issues
  • 36 of those are unassigned
• 0 P-critical, 0 P-high, 1 P-medium, 1 P-low regression-from-stable-to-beta
• 0 P-critical, 1 P-high, 5 P-medium, 2 P-low regression-from-stable-to-nightly
• 0 P-critical, 37 P-high, 100 P-medium, 15 P-low regression-from-stable-to-stable

P-critical

T-compiler

• No P-critical issues for T-compiler this time.

T-types

• No P-critical issues for T-types this time.

P-high regressions

P-high beta regressions

• No P-high beta regressions this time.

Unassigned P-high nightly regressions

• No unassigned P-high nightly regressions this time.

Performance logs

triage logs for 2023-03-19

Even though the summary might not look like it, this was actually a relatively quiet week, with a few small regressions. The large regression that is also shown in the summary table was caused by extending the verification of incremental compilation results. However, this verification is not actually fully enabled by default, so these regressions are mostly only visible in our benchmarking suite, which enables the verification to achieve more deterministic benchmarking results. One small regression was also caused by enabling frame pointers for the Rust standard library, which should improve profiling of Rust programs.

Triage done by @kobzol. Revision range: e919669d..21d94a3d

Summary:

4 Regressions, 1 Improvements, 6 Mixed; 4 of them in rollups 67 artifact comparisons made in total

Regressions

Make DefiningAnchor::Bind only store the opaque types that may be constrained, instead of the current infcx root item. #121796 (Comparison Link)

• This is a refactoring of the “old” trait solver that was necessary for follow-up compiler changes.

Rollup of 12 pull requests #122389 (Comparison Link)

• Noise, marked as triaged.

Verify that query keys result in unique dep nodes #122227 (Comparison Link)

• This PR adds additional verification to the compiler that checks if incremental compilation didn’t encounter problems.
• This result looks quite bad, but that is mostly caused by the configuration of our benchmark suite, which fully enables this verification to make benchmarking more deterministic.
• Normal builds of user code should not be affected by this change.

Enable frame pointers for the standard library #122646 (Comparison Link)

• This PR has a small instruction count cost across the board, but cycles and walltime were affected much less.
• It enables frame pointers for the Rust standard library, which should make profiling of Rust code more robust and accurate, which should be worth this small perf. hit.
• Marked as triaged.

Improvements

Rollup of 15 pull requests #122338 (Comparison Link)

Mixed

Update cargo #122394 (Comparison Link)

• Most likely noise.

more eagerly instantiate binders #119849 (Comparison Link)

• A small regression for trait-heavy crates, caused by a fix to the trait solver.
• Marked as triaged.

Rollup of 9 pull requests #122607 (Comparison Link)

• The largest regression was caused by #122601, which should enable more LLVM optimizations, so some regressions to opt benchmarks is expected.
• Marked as triaged.

Move generic NonZero rustc_layout_scalar_valid_range_start attribute to inner type. #121885 (Comparison Link)

• A small regression caused by internal refactoring in the compiler. Marked as triaged.

Rollup of 8 pull requests #122690 (Comparison Link)

• Most likely noise, marked as triaged.

Rollup of 11 pull requests #122713 (Comparison Link)

• Small regression in match checking caused by #121823, which improves compiler diagnostics.
• Marked as triaged.

Nominated Issues

T-compiler

• No I-compiler-nominated issues this time.

RFC

• No I-compiler-nominated RFCs this time.

Oldest PRs waiting for review

T-compiler

• “Enable DestinationPropagation by default.” rust#115105 (last review activity: 2 months ago)
  • cc: @tm|352985
• “Suggest ref mut for pattern matching assignment” rust#119650 (last review activity: about 54 days ago)
  • cc: @Wesley Wiser
• “Small improvements to internal documentation” rust#120388 (last review activity: about 54 days ago)
  • cc: @Esteban Küber
• “Update rustc_codegen_cranelift’s dependencies” rust#119741 (last review activity: about 53 days ago)
  • cc @bjorn3

Next week’s WG checkins

• @_WG-llvm by @nagisa and @Nikita Popov
• @_WG-mir-opt by @oli

Next meetings' agenda draft: hackmd link